Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
Date
Msg-id 20140528205528.GB27914@awork2.anarazel.de
Whole thread Raw
In response to pgsql: Fix bogus %name-prefix option syntax in all our Bison files.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
List pgsql-committers
Hi,

On 2014-05-28 19:42:35 +0000, Tom Lane wrote:
> Fix bogus %name-prefix option syntax in all our Bison files.
>
> %name-prefix doesn't use an "=" sign according to the Bison docs, but it
> silently accepted one anyway, until Bison 3.0.  This was originally a
> typo of mine in commit 012abebab1bc72043f3f670bf32e91ae4ee04bd2, and we
> seem to have slavishly copied the error into all the other grammar files.
>
> Per report from Vik Fearing; analysis by Peter Eisentraut.

Are you sure about this? When I saw those warnings first after debian
unstable got bison 3.0 I've read the release notes and interpreted it
differently: By accident *only* the = syntax worked for a long time. Then
somewhere around 2.8 they added the syntax without =. That means that <
2.8 versions are likely not to work anymore.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Minor refactoring of jsonb_util.c
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.