Re: pgsql: Move pg_lzcompress.c to src/common. - Mailing list pgsql-committers

On 2014-12-25 23:46:52 +0900, Michael Paquier wrote:
> On Thu, Dec 25, 2014 at 10:43 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> > /*
> >  * We have to use postgres.h not postgres_fe.h here, because there's so much
> >  * backend-only stuff in the XLOG include files we need.  But we need a
> >  * frontend-ish environment otherwise.  Hence this ugly hack.
> >  */
> > #define FRONTEND 1
> >
> > #include "postgres.h"
> Urgh.. Would that mean keeping a local copy of SET_VARSIZE_4B_C and
> VARSIZE_4B if this hack is not used? Looking at the git history, I am
> seeing similar things in 2008 where pg_crc stuff was moved to src/port
> (5c9c08d).

Surely not. It seems like a much better idea to not have lzcompress deal
with varlena at all but pass that responsibility one layer upwards. That
shouldn't be very hard.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services