Re: Raising our compiler requirements for 9.6 - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Raising our compiler requirements for 9.6
Date
Msg-id 20150805141552.GG12598@awork2.anarazel.de
Whole thread Raw
In response to Re: Raising our compiler requirements for 9.6  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Raising our compiler requirements for 9.6
List pgsql-hackers
On 2015-08-05 10:08:10 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2015-08-05 14:05:24 +0200, Andres Freund wrote:
> >> So unless somebody protests I'm going to prepare (and commit after
> >> posting) a patch to rip out the bits of code that currently depend on
> >> PG_USE_INLINE.
> 
> > Here's that patch. I only removed code dependant on PG_USE_INLINE. We
> > might later want to change some of the harder to maintain macros to
> > inline functions, but that seems better done separately.
> 
> Hmm.  I notice that this removes Noah's hack from commit c53f73879f552a3c.
> Do we care about breaking old versions of xlc, and if so, how are we going
> to fix that?  (I assume it should be possible to override AC_C_INLINE's
> result, but I'm not sure where would be a good place to do so.)

Hm. That's a good point.

How about moving that error check into into the aix template file and
erroring out there? Since this is master I think it's perfectly fine to
refuse to work with the buggy unsupported 32 bit compiler. The argument
not to do so was that PG previously worked in the back branches
depending on the minor version, but that's not an argument on master.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Raising our compiler requirements for 9.6
Next
From: Tom Lane
Date:
Subject: Re: Raising our compiler requirements for 9.6