Re: show xl_prev in xlog.c errcontext - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: show xl_prev in xlog.c errcontext
Date
Msg-id 20160404211440.GA236605@alvherre.pgsql
Whole thread Raw
In response to Re: show xl_prev in xlog.c errcontext  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: show xl_prev in xlog.c errcontext
List pgsql-hackers
Michael Paquier wrote:
> On Thu, Apr 16, 2015 at 3:25 PM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> > On 04/15/2015 11:35 PM, Alvaro Herrera wrote:
> >>
> >> I found this patch in my local repo that I wrote some weeks or months
> >> ago while debugging some XLog corruption problem: it was difficult to
> >> pinpoint what XLog record in a long sequence of WAL files was causing a
> >> problem, and the displaying the prev pointer in errcontext made finding
> >> it much easier -- I could correlate it with pg_xlogdump output, I think.
> >
> > Seems like a good idea, but why print the prev pointer, and not the location
> > of the record itself?

Makes sense -- pushed that way.

> And both?

I couldn't see much point of doing this, so I didn't.  If you have a
rationale for it, let's hear it.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Oleksii Kliukin
Date:
Subject: Re: WIP: Failover Slots
Next
From: Petr Jelinek
Date:
Subject: Re: Timeline following for logical slots