Andres Freund wrote:
> - /* oldest LSN that the client has acked receipt for */
> + /*
> + * Oldest LSN that the client has acked receipt for. This is used as the
> + * start_lsn point in case the client doesn't specify one, and also as a
> + * safety measure to back off in case the client specifies a start_lsn
> + * that's further in the future than this value.
> + */
> XLogRecPtr confirmed_flush;
>
> This is the wrong way round. confirmed_flush is used if the client's
> start_lsn is further in the *past* than this value.
Bah. Funnily enough I got this one right in the comment for
CreateDecodingContext.
Thanks for reading through the commit.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
