Postgres Pro
Downloads
Home   >   mailing lists

Re: Comment and function argument names are mismatched in bugmgr.c. - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Comment and function argument names are mismatched in bugmgr.c.
Date
Msg-id 20160701213403.l2cl4xsqwarfj2nm@alap3.anarazel.de
Whole thread Raw
In response to Comment and function argument names are mismatched in bugmgr.c.  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Comment and function argument names are mismatched in bugmgr.c.
List pgsql-hackers
Tree view 
Hi,

On 2016-06-23 16:24:12 +0900, Masahiko Sawada wrote:
> By commit 428b1d6b, function WritebackContextInit is added but the
> comment of this function seems to be incorrect.
> *max_coalesce variable doesn't exist at anywhere.
> Also, I think it should be fixed that the argument name of this
> function does not match function declare in buf_internal.h.
> Patch for that attached.

Fix looks good to me, and your 'bugmgr.c' typo in $subject made me laugh
;). Pushed.

Thanks Robert, for pointing me to the thread, I had indeed missed it.

Greetings,

Andres Freund

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [sqlsmith] ERROR: plan should not reference subplan's variable
Next
From: Andres Freund
Date:
Subject: Re: pg_replication_origin_xact_reset() and its argument variables