Re: [HACKERS] [patch] psql tab completion for ALTER DEFAULTPRIVILEGES - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [HACKERS] [patch] psql tab completion for ALTER DEFAULTPRIVILEGES
Date
Msg-id 20161223032740.GV18360@tamriel.snowman.net
Whole thread Raw
In response to Re: [patch] psql tab completion for ALTER DEFAULT PRIVILEGES  (Gilles Darold <gilles.darold@dalibo.com>)
Responses Re: [HACKERS] [patch] psql tab completion for ALTER DEFAULTPRIVILEGES
List pgsql-hackers
Gilles,

* Gilles Darold (gilles.darold@dalibo.com) wrote:
> Added to next commitfest. To explain more this patch, the completion of
> SQL command:
>
>     ALTER DEFAULT PRIVILEGES FOR ROLE xxx [tab]

Here is a cleaned up patch for master and 9.6.  Tomorrow I'll look into
what we can do for 9.5 and earlier, which are also wrong, but the code
is quite a bit different.

Note that beyond just changing the comments, I removed the alternative
spelling of 'role' when doing tab completion- there's no different
between 'role' and 'user', so there's no point in making the user have
to pick one when they're tab-completing.  Of course, we still accept
both and if the user chooses to write out 'for user', we will handle
that correctly and continue the tab completion beyond that.

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers
Next
From: Ashutosh Bapat
Date:
Subject: Re: [HACKERS] multi-level partitions and partition-wise joins