Re: pgsql: Add \if support to pgbench - Mailing list pgsql-committers

On 2018-03-22 14:42:26 +0000, Teodor Sigaev wrote:
> Add \if support to pgbench
> 
> Patch adds \if to pgbench as it done for psql. Implementation shares condition
> stack code with psql, so, this code is moved to fe_utils directory.
> 
> Author: Fabien COELHO with minor editorization by me
> Review by: Vik Fearing, Fedor Sigaev
> Discussion: https://www.postgresql.org/message-id/flat/alpine.DEB.2.20.1711252200190.28523@lancre

This broke MSVC in some way, apparently:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk&dt=2018-03-22%2016%3A41%3A07
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2018-03-22%2016%3A30%3A25

Suspect it didn't update the msvc project build infrastructure.

"C:\buildfarm\buildenv\HEAD\pgsql.build\pgsql.sln" (Standardziel) (1) ->
"C:\buildfarm\buildenv\HEAD\pgsql.build\pgbench.vcxproj" (Standardziel) (100) ->
(Link Ziel) -> 
  pgbench.obj : error LNK2019: unresolved external symbol _conditional_stack_create referenced in function
_CheckConditional[C:\buildfarm\buildenv\HEAD\pgsql.build\pgbench.vcxproj]
 
  pgbench.obj : error LNK2019: unresolved external symbol _conditional_stack_destroy referenced in function
_CheckConditional[C:\buildfarm\buildenv\HEAD\pgsql.build\pgbench.vcxproj]
 
  pgbench.obj : error LNK2019: unresolved external symbol _conditional_stack_push referenced in function _doCustom
[C:\buildfarm\buildenv\HEAD\pgsql.build\pgbench.vcxproj]
  pgbench.obj : error LNK2019: unresolved external symbol _conditional_stack_pop referenced in function _doCustom
[C:\buildfarm\buildenv\HEAD\pgsql.build\pgbench.vcxproj]
  pgbench.obj : error LNK2019: unresolved external symbol _conditional_stack_peek referenced in function _doCustom
[C:\buildfarm\buildenv\HEAD\pgsql.build\pgbench.vcxproj]
  pgbench.obj : error LNK2019: unresolved external symbol _conditional_stack_poke referenced in function _doCustom
[C:\buildfarm\buildenv\HEAD\pgsql.build\pgbench.vcxproj]
  pgbench.obj : error LNK2019: unresolved external symbol _conditional_stack_empty referenced in function _doCustom
[C:\buildfarm\buildenv\HEAD\pgsql.build\pgbench.vcxproj]
  pgbench.obj : error LNK2019: unresolved external symbol _conditional_active referenced in function _doCustom
[C:\buildfarm\buildenv\HEAD\pgsql.build\pgbench.vcxproj]
  .\Release\pgbench\pgbench.exe : fatal error LNK1120: 8 unresolved externals
[C:\buildfarm\buildenv\HEAD\pgsql.build\pgbench.vcxproj]


"C:\buildfarm\buildenv\HEAD\pgsql.build\pgsql.sln" (Standardziel) (1) ->
"C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj" (Standardziel) (109) ->
  command.obj : error LNK2019: unresolved external symbol _conditional_stack_push referenced in function
_HandleSlashCmds[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
 
  command.obj : error LNK2019: unresolved external symbol _conditional_stack_pop referenced in function
_HandleSlashCmds[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
 
  mainloop.obj : error LNK2001: unresolved external symbol _conditional_stack_pop
[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
  command.obj : error LNK2019: unresolved external symbol _conditional_stack_peek referenced in function
_exec_command_elif[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
 
  command.obj : error LNK2019: unresolved external symbol _conditional_stack_poke referenced in function
_exec_command_elif[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
 
  psqlscanslash.obj : error LNK2001: unresolved external symbol _conditional_active
[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
  command.obj : error LNK2001: unresolved external symbol _conditional_active
[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
  common.obj : error LNK2001: unresolved external symbol _conditional_active
[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
  mainloop.obj : error LNK2001: unresolved external symbol _conditional_active
[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
  prompt.obj : error LNK2001: unresolved external symbol _conditional_active
[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
  command.obj : error LNK2019: unresolved external symbol _conditional_stack_set_query_len referenced in function
_exec_command_if[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
 
  command.obj : error LNK2019: unresolved external symbol _conditional_stack_get_query_len referenced in function
_discard_query_text[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
 
  command.obj : error LNK2019: unresolved external symbol _conditional_stack_set_paren_depth referenced in function
_exec_command_if[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
 
  command.obj : error LNK2019: unresolved external symbol _conditional_stack_get_paren_depth referenced in function
_discard_query_text[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
 
  mainloop.obj : error LNK2019: unresolved external symbol _conditional_stack_create referenced in function _MainLoop
[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
  startup.obj : error LNK2001: unresolved external symbol _conditional_stack_create
[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
  mainloop.obj : error LNK2019: unresolved external symbol _conditional_stack_destroy referenced in function _MainLoop
[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
  startup.obj : error LNK2001: unresolved external symbol _conditional_stack_destroy
[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
  mainloop.obj : error LNK2019: unresolved external symbol _conditional_stack_empty referenced in function _MainLoop
[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]
  .\Release\psql\psql.exe : fatal error LNK1120: 12 unresolved externals
[C:\buildfarm\buildenv\HEAD\pgsql.build\psql.vcxproj]

    59 Warnung(en)
    29 Fehler

Verstrichene Zeit 00:07:44.30