Re: [HACKERS] Restricting maximum keep segments by repslots - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Restricting maximum keep segments by repslots
Date
Msg-id 20180720042520.GD7023@paquier.xyz
Whole thread Raw
In response to Re: [HACKERS] Restricting maximum keep segments by repslots  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
On Fri, Jul 20, 2018 at 10:13:58AM +0900, Masahiko Sawada wrote:
> Also, I'm not sure it's a good way to show the distance as LSN. LSN is
> a monotone increasing value but in your patch, a value of the "remain"
> column can get decreased.

If that can happen, I think that this is a very, very bad idea.  A
couple of code paths, including segment recycling and the new WAL
advancing rely on such monotonic properties.  That would be also very
confusing for any monitoring job looking at pg_replication_slots.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Possible performance regression in version 10.1 with pgbench read-write tests.
Next
From: Michael Paquier
Date:
Subject: Re: de-deduplicate code in DML execution hooks in postgres_fdw