Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Change "checkpoint starting" message to use "wal" - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Change "checkpoint starting" message to use "wal"
Date
Msg-id 20181129090952.GH9004@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Change "checkpoint starting" message to use "wal"  (Christoph Berg <christoph.berg@credativ.de>)
Responses Re: [PATCH] Change "checkpoint starting" message to use "wal"
List pgsql-hackers
Tree view 
On Thu, Nov 29, 2018 at 10:04:12AM +0100, Christoph Berg wrote:
> There's hundreds of other internal uses of xlog that were not touched
> either, only the user-facing parts were changed.

I have heard of them ;)
Just wondering if this one is worth renaming as the variable is
isolated.  It is not a big deal to do nothing though.

> If this gets accepted, I'll submit a patch for pgbadger so it can be
> updated before PG12 hits the field.

Your change looks acceptable to me FWIW.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add pg_partition_tree to doc index
Next
From: legrand legrand
Date:
Subject: Re: [PROPOSAL] extend the object names to the qualified names inpg_stat_statements