Postgres Pro
Downloads
Home   >   mailing lists

Re: remove some STATUS_* symbols - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: remove some STATUS_* symbols
Date
Msg-id 20200110052332.GI1702@paquier.xyz
Whole thread Raw
In response to Re: remove some STATUS_* symbols  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: remove some STATUS_* symbols
List pgsql-hackers
Tree view 
On Thu, Jan 09, 2020 at 11:15:08AM +0100, Peter Eisentraut wrote:
> You mean put he subsequent GrantLock() calls into LockCheckConflicts()? That
> would technically save some duplicate code, but it seems weird, because
> LockCheckConflicts() is notionally a read-only function that shouldn't
> change state.

Nah.  I was thinking about the first part of this "if" clause
LockCheckConflicts is part of here:
   if (lockMethodTable->conflictTab[lockmode] & lock->waitMask)
       status = STATUS_FOUND;
   else
       status = LockCheckConflicts(lockMethodTable, lockmode,
                                   lock, proclock);

But now that I look at it closely it messes up heavily with
ProcSleep() ;)
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions
Next
From: Dilip Kumar
Date:
Subject: Re: [Logical Replication] TRAP: FailedAssertion("rel->rd_rel->relreplident== REPLICA_IDENTITY_DEFAULT || rel->rd_rel->relreplident ==REPLICA_IDENTITY_FULL || rel->rd_rel->relreplident == REPLICA_IDENTITY_INDEX"