Re: Getting rid of some more lseek() calls - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Getting rid of some more lseek() calls
Date
Msg-id 20200212163025.GA8864@alvherre.pgsql
Whole thread Raw
In response to Re: Getting rid of some more lseek() calls  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Getting rid of some more lseek() calls
List pgsql-hackers
On 2020-Feb-12, Thomas Munro wrote:

> Hmm.  Well, on Unix we have to choose between "tell me the size but
> also change the position that I either don't care about or have to
> undo", and "tell me the size but also tell me all this other stuff I
> don't care about".  Since Windows apparently has GetFileSizeEx(), why
> not use that when that's exactly what you want?  It apparently
> understands large files.

I was already thinking that it might be better to make the new function
just "tell me the file size" without leaking the details of *how* we do
it, before reading about this Windows call.  That reinforces it, IMO.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Juan José Santamaría Flecha
Date:
Subject: Re: Just for fun: Postgres 20?
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager