Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date
Msg-id 20200306191655.gm7hjex5c7znmomr@alap3.anarazel.de
Whole thread Raw
In response to Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h  (David Steele <david@pgmasters.net>)
List pgsql-committers
Hi,

On 2020-03-05 12:51:50 -0500, David Steele wrote:
> On 3/5/20 12:13 AM, Michael Paquier wrote:
> > Avoid -Wconversion warnings when using checksum_impl.h
> > 
> > This does not matter much when compiling Postgres proper as many
> > warnings exist when enabling this compilation flag, but it can be
> > annoying for external modules willing to use both.
> 
> Looks like you changed 65535 -> 65536 before commit.  I checked the original
> patch and it has 65535.

I gotta say, that's something that just shouldn't happen.

Greetings,

Andres Freund



pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Allow ALTER TYPE to change some properties of a base type.
Next
From: Tom Lane
Date:
Subject: pgsql: Allow Unicode escapes in any server encoding, not only UTF-8.