Re: 2pc leaks fds - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: 2pc leaks fds
Date
Msg-id 20200511162554.GA10483@alvherre.pgsql
Whole thread Raw
In response to Re: 2pc leaks fds  (Antonin Houska <ah@cybertec.at>)
List pgsql-hackers
Hi Antonin, thanks for the review.


On 2020-May-11, Antonin Houska wrote:

> While looking at the changes, I've noticed a small comment issue in the
> XLogReaderRoutine structure definition:
> 
>     * "tli_p" is an input/output argument. XLogRead() uses it to pass the
> 
> The XLogRead() function has been renamed to WALRead() in 0dc8ead4. (This
> incorrect comment was actually introduced by that commit.)

Ah.  I'll fix this, thanks for pointing it out.

(It might be that the TLI situation can be improved with some callback,
too.)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: making update/delete of inheritance trees scale better
Next
From: Mark Dilger
Date:
Subject: Re: new heapcheck contrib module