Re: pgsql: Prefetch data referenced by the WAL, take II. - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pgsql: Prefetch data referenced by the WAL, take II.
Date
Msg-id 20220904075450.6g4nm4hralyw3tab@alvherre.pgsql
Whole thread Raw
Responses Re: pgsql: Prefetch data referenced by the WAL, take II.
List pgsql-hackers
On 2022-Apr-07, Thomas Munro wrote:

> Prefetch data referenced by the WAL, take II.

I propose a small wording change in guc.c,

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 9fbbfb1be5..9803741708 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -2840,7 +2840,7 @@ static struct config_int ConfigureNamesInt[] =
     {
         {"wal_decode_buffer_size", PGC_POSTMASTER, WAL_RECOVERY,
             gettext_noop("Maximum buffer size for reading ahead in the WAL during recovery."),
-            gettext_noop("This controls the maximum distance we can read ahead in the WAL to prefetch referenced
blocks."),
+            gettext_noop("This controls the maximum distance we can read ahead in the WAL to prefetch data blocks
referencedtherein."),
 
             GUC_UNIT_BYTE
         },
         &wal_decode_buffer_size,

"referenced blocks" seems otherwise a bit unclear to me.  Other wording
suggestions welcome.  I first thought of "...to prefetch referenced data
blocks", which is probably OK too.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().
Next
From: Ibrar Ahmed
Date:
Subject: Re: pgbench: using prepared BEGIN statement in a pipeline could cause an error