Re: RFC: Logging plan of the running query - Mailing list pgsql-hackers

Hi,

This patch does not currently build, due to a conflicting oid:

https://cirrus-ci.com/task/4638460594618368?logs=build#L108
[17:26:44.602] /usr/bin/perl ../src/include/catalog/../../backend/catalog/genbki.pl --include-path=../src/include
--set-version=16--output=src/include/catalog ../src/include/catalog/pg_proc.h ../src/include/catalog/pg_type.h
../src/include/catalog/pg_attribute.h../src/include/catalog/pg_class.h ../src/include/catalog/pg_attrdef.h
../src/include/catalog/pg_constraint.h../src/include/catalog/pg_inherits.h ../src/include/catalog/pg_index.h
../src/include/catalog/pg_operator.h../src/include/catalog/pg_opfamily.h ../src/include/catalog/pg_opclass.h
../src/include/catalog/pg_am.h../src/include/catalog/pg_amop.h ../src/include/catalog/pg_amproc.h
../src/include/catalog/pg_language.h../src/include/catalog/pg_largeobject_metadata.h
../src/include/catalog/pg_largeobject.h../src/include/catalog/pg_aggregate.h ../src/include/catalog/pg_statistic.h
../src/include/catalog/pg_statistic_ext.h../src/include/catalog/pg_statistic_ext_data.h
../src/include/catalog/pg_rewrite.h../src/include/catalog/pg_trigger.h ../src/include/catalog/pg_event_trigger.h
../src/include/catalog/pg_description.h../src/include/catalog/pg_cast.h ../src/include/catalog/pg_enum.h
../src/include/catalog/pg_namespace.h../src/include/catalog/pg_conversion.h ../src/include/catalog/pg_depend.h
../src/include/catalog/pg_database.h../src/include/catalog/pg_db_role_setting.h ../src/include/catalog/pg_tablespace.h
../src/include/catalog/pg_authid.h../src/include/catalog/pg_auth_members.h ../src/include/catalog/pg_shdepend.h
../src/include/catalog/pg_shdescription.h../src/include/catalog/pg_ts_config.h
../src/include/catalog/pg_ts_config_map.h../src/include/catalog/pg_ts_dict.h ../src/include/catalog/pg_ts_parser.h
../src/include/catalog/pg_ts_template.h../src/include/catalog/pg_extension.h
../src/include/catalog/pg_foreign_data_wrapper.h../src/include/catalog/pg_foreign_server.h
../src/include/catalog/pg_user_mapping.h../src/include/catalog/pg_foreign_table.h ../src/include/catalog/pg_policy.h
../src/include/catalog/pg_replication_origin.h../src/include/catalog/pg_default_acl.h
../src/include/catalog/pg_init_privs.h../src/include/catalog/pg_seclabel.h ../src/include/catalog/pg_shseclabel.h
../src/include/catalog/pg_collation.h../src/include/catalog/pg_parameter_acl.h
../src/include/catalog/pg_partitioned_table.h../src/include/catalog/pg_range.h ../src/include/catalog/pg_transform.h
../src/include/catalog/pg_sequence.h../src/include/catalog/pg_publication.h
../src/include/catalog/pg_publication_namespace.h../src/include/catalog/pg_publication_rel.h
../src/include/catalog/pg_subscription.h../src/include/catalog/pg_subscription_rel.h 
[17:26:44.602] Duplicate OIDs detected:
[17:26:44.602] 4550
[17:26:44.602] found 1 duplicate OID(s) in catalog data

I suggest you choose a random oid out of the "development purposes" range:

 *        OIDs 1-9999 are reserved for manual assignment (see .dat files in
 *        src/include/catalog/).  Of these, 8000-9999 are reserved for
 *        development purposes (such as in-progress patches and forks);
 *        they should not appear in released versions.

Greetings,

Andres Freund