On 2023-Sep-27, Amit Langote wrote:
> Maybe the following is better:
>
> + /*
> + * For expression nodes that support soft errors. Should be set to NULL
> + * before calling ExecInitExprRec() if the caller wants errors thrown.
> + */
>
> ...as in the attached.
That's good.
> Alvaro, do you think your concern regarding escontext not being in the
> right spot in the ExprState struct is addressed? It doesn't seem very
> critical to me to place it in the struct's 1st cacheline, because
> escontext is not accessed in performance critical paths such as during
> expression evaluation, especially with the latest version. (It would
> get accessed during evaluation with previous versions.)
>
> If so, I'd like to move ahead with committing it.
Yeah, looks OK to me in v21.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
