Re: Running the fdw test from the terminal crashes into the core-dump - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Running the fdw test from the terminal crashes into the core-dump
Date
Msg-id 202402211653.zuh6objy3z72@alvherre.pgsql
Whole thread Raw
In response to Re: Running the fdw test from the terminal crashes into the core-dump  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Running the fdw test from the terminal crashes into the core-dump
List pgsql-hackers
On 2024-Feb-20, Tom Lane wrote:

> > So, this means we can fix this by simply requiring ACL_SELECT privileges
> > on a DO NOTHING action.  We don't need to request specific privileges on
> > any particular column (perminfo->selectedCols continues to be the empty
> > set) -- which means that any role that has privileges on *any* column
> > would get a pass.
> 
> LGTM.

Thanks for looking!

After having pushed that, I wonder if we should document this.  It seems
quite the minor thing, but I'm sure somebody will complain if we don't.
I propose the attached.  (Extra context so that the full paragraph can
be read from the comfort of your email program.)

(While at it, I found the placement of the previous-to-last sentence in
that paragraph rather strange, so I moved it to the end.)

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Sallah, I said NO camels! That's FIVE camels; can't you count?"
(Indiana Jones)

Attachment

pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Re: Patch: Add parse_type Function
Next
From: David Wheeler
Date:
Subject: Re: to_regtype() Raises Error