Re: overflow bug for inhcounts - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: overflow bug for inhcounts
Date
Msg-id 202410101638.qikdezkpvups@alvherre.pgsql
Whole thread Raw
List pgsql-hackers
On 2024-Oct-09, jian he wrote:

> CreateConstraintEntry(const char *constraintName,

> we can change
> int conInhCount,
> to
> int16 conInhCount.
> doing that, meaning we also need to refactor some of the caller functions.

Good thought, thanks.

> we can also change
> node Constraint field inhcount from int to int16.

Nah, that field is unused, so I removed it.  I gave another look at the
not-nulls branch, and we can do without it.

This is pushed, although there was a technical glitch (since fixed by
Magnus Hagander) and the pgsql-committers message was not sent.  But you
can see it here:

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=fd64ed60b62697984bb69a09a3ae19fbe2905eb6

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: ECPG Refactor: move sqlca variable in ecpg_log()
Next
From: Tom Lane
Date:
Subject: Re: Build issue with postgresql 17 undefined reference to `pg_encoding_to_char' and `pg_char_to_encoding'