On Thu, Jan 23, 2025 at 01:51:32PM -0500, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > On Thu, Jan 23, 2025 at 01:22:13PM -0500, Tom Lane wrote:
> >> An alternative idea (that maybe should also be done in PostmasterMain)
> >> is to report the HINT only #ifdef __darwin__ and on other platforms
> >> use the "Please report a bug" text.
>
> > I gather pthread_is_threaded_np() is still macOS-only, in which case the
> > !darwin branch would be future-proofing only.
>
> Ah, I had not realized that. Perhaps the comments about this code
> should mention that?
Sure, your committed comment works for me.
> > Another alternative would be to track whether we reached the startup-time
> > check, emitting a message at exit only if we did reach the startup-time check.
> > If a postmaster passes the startup-time check and fails the exit-time check,
> > changing the environment won't help. Even so, I'm content with your first
> > proposal.
>
> Yeah, seems like overcomplication. Let's go with the simple way.
postgr.es/c/4f15759bdcddd23e874526a6b2c0ff86e0beb042 looks fine. Thanks.
