Re: pg_createsubscriber --dry-run logging concerns - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: pg_createsubscriber --dry-run logging concerns
Date
Msg-id 202510041156.qwirsemadsvd@alvherre.pgsql
Whole thread Raw
In response to Re: pg_createsubscriber --dry-run logging concerns  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
On 2025-Oct-03, Peter Smith wrote:

> Summary
> 
> The idea to change the pg_log_info macro globally seems risky. There
> are 400+ usages of this in the PG code, way beyond the scope of these
> few tools that have a dry-run.

Ok.

> So, that makes pg_createsubscriber the odd man out. Instead of
> introducing a new logging macro, perhaps it's better (for code
> consistency) just to change pg_createsubscriber to use that same
> logging pattern.

Sure, let's go that way.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Xuneng Zhou
Date:
Subject: Re: Improve read_local_xlog_page_guts by replacing polling with latch-based waiting
Next
From: "David E. Wheeler"
Date:
Subject: Re: [PATCH] random_normal function