Re: VACUUM (PARALLEL) option processing not using DefElem the way it was intended - Mailing list pgsql-hackers

On 2025-Oct-08, David Rowley wrote:

> I was just looking at the VACUUM option processing and I saw that the
> code to process the PARALLEL option doesn't make use of the code in
> defGetInt32() that's meant to handle empty and non-integer parameters.
> ExecVacuum() has code to handle an empty PARALLEL parameters, but not
> non-integer ones. That goes through to defGetInt32().

Yeah, that change makes sense to me.  With an eye towards not forcing
the translators to understand the message context or forced to translate
the word "parallel", I would suggest to take the option name out of the
sentence, maybe something like

  value for VACUUM option \"%s\" must be between 0 and %d

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/