Re: VACUUM (PARALLEL) option processing not using DefElem the way it was intended - Mailing list pgsql-hackers

On 2025-Oct-08, Masahiko Sawada wrote:

> I noticed we're currently hardcoding the "BUFFER_USAGE_LIMIT" option
> name in the error message:
> 
> ereport(ERROR,
>          (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>           errmsg("BUFFER_USAGE_LIMIT option must be 0 or between %d kB
> and %d kB",
>                  MIN_BAS_VAC_RING_SIZE_KB, MAX_BAS_VAC_RING_SIZE_KB),
>           hintmsg ? errhint("%s", _(hintmsg)) : 0));
> 
> Should we also change this for consistency with how we handle other
> VACUUM options?

I would appreciate that, and also a change there from errhint() to
errhint_internal.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Los dioses no protegen a los insensatos.  Éstos reciben protección de
otros insensatos mejor dotados" (Luis Wu, Mundo Anillo)