Re: pg_createsubscriber --dry-run logging concerns - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: pg_createsubscriber --dry-run logging concerns
Date
Msg-id 202510311750.mxiykx3tp4mx@alvherre.pgsql
Whole thread Raw
In response to Re: pg_createsubscriber --dry-run logging concerns  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: pg_createsubscriber --dry-run logging concerns
List pgsql-hackers
On 2025-Oct-09, Peter Smith wrote:

> Please see the v3 patches.

Okay, I have pushed 0002 to 18 and master.  I wanted to backpatch to 17
but there are too many conflicts there.

I'm not opposed to 0001 (to master only), but I think the lines of
dashes are a little excessively noisy.  Are there other opinions on
that?  Note that vacuumlo also has it, with no dashes.

I'll mark the commitfest item for version 19.

While looking this over, I noticed that we define USEC_PER_SEC, but why?
We already have USECS_PER_SEC, so let's use that.  And WaitPMResult
seems an overgrown boolean, so how about we remove it?  Patch for these
things attached.  Thoughts?

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
Thou shalt study thy libraries and strive not to reinvent them without
cause, that thy code may be short and readable and thy days pleasant
and productive. (7th Commandment for C Programmers)

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Fully documenting the design of nbtree row comparison scan keys
Next
From: Tom Lane
Date:
Subject: Re: Should HashSetOp go away