Re: BRIN autosummarization lacking a snapshot - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: BRIN autosummarization lacking a snapshot
Date
Msg-id 202511041733.vkh6l7rzcwjg@alvherre.pgsql
Whole thread Raw
In response to Re: BRIN autosummarization lacking a snapshot  (Álvaro Herrera <alvherre@kurilemu.de>)
List pgsql-hackers
On 2025-Nov-04, Álvaro Herrera wrote:

> Ah, the problem is that perform_work_item() pushes an active snapshot
> before calling the BRIN function, but because of the error, we
> terminate the transaction before returning, so when we try to Pop that
> snapshot, it doesn't exist anymore.  Other ways for this to happen would
> be an autovacuum worker trying to run an item for a dropped table (the
> "goto deleted2" case).

Of course, the answer is just to inquire ActiveSnapshotSet() beforehand.
I tested this by adding an elog(ERROR) in perform_work_item() -- without
this fix, I see a segfault, which disappears with it.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Debido a que la velocidad de la luz es mucho mayor que la del sonido,
 algunas personas nos parecen brillantes un minuto antes
 de escuchar las pelotudeces que dicen." (Roberto Fontanarrosa)

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Fix ALTER SYSTEM empty string bug for GUC_LIST_QUOTE parameters
Next
From: Jeff Davis
Date:
Subject: Re: Fix redundant memset after palloc0 in heap_form_minimal_tuple()