Request a Demo
Home   >   mailing lists

Re: Add IS_INDEX macro to brin and gist index - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Add IS_INDEX macro to brin and gist index
Date
Msg-id 202601141537.xogppfpwrpyh@alvherre.pgsql
Whole thread Raw
In response to Re: Add IS_INDEX macro to brin and gist index  (Japin Li <japinli@hotmail.com>)
Responses Re: Add IS_INDEX macro to brin and gist index
List pgsql-hackers
Tree view 
On 2026-Jan-14, Japin Li wrote:

> -#define IS_INDEX(r) ((r)->rd_rel->relkind == RELKIND_INDEX)
> -#define IS_BTREE(r) ((r)->rd_rel->relam == BTREE_AM_OID)
> +#define IS_BTREE(r) (IS_INDEX(r) && (r)->rd_rel->relam == BTREE_AM_OID)

I find this coding rather pointless.  You can more easily do something
like

#define IS_BTREE(r) ((r)->rd_rel->relkind == RELKIND_INDEX && (r)->rd_rel->relam == BTREE_AM_OID)

and get rid of the IS_INDEX macro completely, if it's not used anywhere
else.  Same for all the other index AMs.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [BUG] [PATCH] pg_basebackup produces wrong incremental files after relation truncation in segmented tables
Next
From: Tatsuya Kawata
Date:
Subject: Re: [PATCH] Add sampling statistics to autoanalyze log output