Re: incompatible pointer types with newer zlib - Mailing list pgsql-hackers

From Tom Lane
Subject Re: incompatible pointer types with newer zlib
Date
Msg-id 20273.1330099816@sss.pgh.pa.us
Whole thread Raw
In response to Re: incompatible pointer types with newer zlib  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: incompatible pointer types with newer zlib
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> On tor, 2012-02-23 at 10:17 -0500, Tom Lane wrote:
>> void * seems entirely reasonable given the two different usages, but
>> I would be happier if the patch added explicit casts whereever FH is
>> set to or used as one of these two types.

> That would add about 70 casts all over the place.  I don't think that
> will make things clearer or more robust.  I think we either leave it as
> my first patch for now or find a more robust solution with a union or
> something.

Hm.  Could we just create two separate fields?  It's not real clear to
me that forcing both these usages into a generic pointer buys much.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Marko Kreen
Date:
Subject: Re: Speed dblink using alternate libpq tuple storage
Next
From: Yeb Havinga
Date:
Subject: Re: [v9.2] Add GUC sepgsql.client_label