Re: Parallel execution and prepared statements - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Parallel execution and prepared statements
Date
Msg-id 21781.1481047678@sss.pgh.pa.us
Whole thread Raw
In response to Re: Parallel execution and prepared statements  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Parallel execution and prepared statements
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> Done.

The comment seems quite confused now:
   * If a tuple count was supplied or data is being written to relation, we   * must force the plan to run without
parallelism,because we might exit   * early.
 

Exit early is exactly what we *won't* do if writing to an INTO rel, so
I think this will confuse future readers.  I think it should be more like
   * If a tuple count was supplied, we must force the plan to run without   * parallelism, because we might exit early.
Also disable parallelism   * when writing into a relation, because [ uh, why exactly? ]
 

Considering that the writing would happen at top level of the executor,
and hence in the parent process, it's not actually clear to me why the
second restriction is there at all: can't we write tuples to a rel even
though they came from a parallel worker?  In any case, the current wording
of the comment is a complete fail at explaining this.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: Separate connection handling from backends
Next
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Account for catalog snapshot in PGXACT->xmin updates.