Re: [HACKERS] s_lock.h busted - Mailing list pgsql-hackers

dg@illustra.com (David Gould) writes:
> Arrrrgggghhh!!!!
> These were meant to be in the conditional blocks at the end of the file so
> that if (and only if) no definition existed we would get a default. So:
> #ifndef S_UNLOCK
> #define S_UNLOCK(lock)  (*(lock) = 0)
> #endif
> #ifndef S_INIT_LOCK
> #define S_INIT_LOCK(lock)       S_UNLOCK(lock)
> #endif

Right, but those default definitions were *already there*.

The lines I was complaining about were added immediately after the
default definitions, and overrode *any* prior definition of the macros.
As far as I can see they were just a typo/thinko.

            regards, tom lane