Put genbki.pl output into src/include/catalog/ directly - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Put genbki.pl output into src/include/catalog/ directly
Date
Msg-id 21b74bdc-183d-4dd5-9c27-9378d178f459@eisentraut.org
Whole thread Raw
Responses Re: Put genbki.pl output into src/include/catalog/ directly
Re: Put genbki.pl output into src/include/catalog/ directly
List pgsql-hackers
With the makefile rules, the output of genbki.pl was written to
src/backend/catalog/, and then the header files were linked to
src/include/catalog/.

This patch changes it so that the output files are written directly to
src/include/catalog/.  This makes the logic simpler, and it also makes
the behavior consistent with the meson build system.  For example, a 
file like schemapg.h is now mentioned only in

src/include/catalog/{meson.build,Makefile,.gitignore}

where before it was mentioned in (checks ...)

src/backend/catalog/.gitignore
src/backend/catalog/Makefile
src/include/Makefile
src/include/catalog/.gitignore
src/include/catalog/meson.build

Also, the list of catalog files is now kept in parallel in
src/include/catalog/{meson.build,Makefile}, while before the makefiles
had it in src/backend/catalog/Makefile.

I think keeping the two build systems aligned this way will be useful 
for longer-term maintenance.

(There are other generated header files that are linked in a similar way 
and could perhaps be simplified.  But they don't all work the same way. 
Some of the scripts also generate .c files, for example, so they need to 
put some stuff under src/backend/.  So I restricted this patch to 
src/{backend,include}/catalog/, especially because it would be good to 
keep the catalog lists aligned.)
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: A comment in DropRole() contradicts the actual behavior
Next
From: Masahiko Sawada
Date:
Subject: Re: Testing autovacuum wraparound (including failsafe)