Re: patch adding new regexp functions - Mailing list pgsql-patches

From Tom Lane
Subject Re: patch adding new regexp functions
Date
Msg-id 22492.1174456206@sss.pgh.pa.us
Whole thread Raw
In response to Re: patch adding new regexp functions  (Neil Conway <neilc@samurai.com>)
Responses Re: patch adding new regexp functions
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> * Comments like "/* get text type oid, too lazy to do it some other way
> */" do not exactly inspire confidence :)

Surely the code was just using the TEXTOID macro?  If so, it does not
require a comment.  If not, it should be fixed ...

            regards, tom lane

pgsql-patches by date:

Previous
From: "Pavan Deolasee"
Date:
Subject: HOT WIP Patch - Version 5.0
Next
From: Jeremy Drake
Date:
Subject: Re: patch adding new regexp functions