Re: [PATCH] Add some documentation on how to call internal functions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Add some documentation on how to call internal functions
Date
Msg-id 2324614.1737142772@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Add some documentation on how to call internal functions  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
Pavel Stehule <pavel.stehule@gmail.com> writes:
> pá 18. 10. 2024 v 22:23 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:
>> The problem here is that we failed to pass through the result of
>> PG_GET_COLLATION() to text_starts_with.  We could do that, certainly,
>> for a couple more lines of code.  But it feels like this is getting
>> into details that obscure the main point.  I wonder if it'd be better
>> to choose a different example that calls a non-collation-dependent
>> target function.

> This can be a trap for some beginners too. So example of
> DirectFunctionCall2Coll can be nice

Hearing no other comments, I fixed the example to pass through
collation and pushed it.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Accept recovery conflict interrupt on blocked writing
Next
From: Tom Lane
Date:
Subject: Re: Set AUTOCOMMIT to on in script output by pg_dump