Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
Date
Msg-id 240328.1755480382@sss.pgh.pa.us
Whole thread Raw
In response to Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> On Mon, 18 Aug 2025 at 13:10, Michael Paquier <michael@paquier.xyz> wrote:
>> If we do that, I guess that we could just remove HASH_DEBUG, keeping
>> only HASH_STATISTICS.

> I wondered about that and thought that there might be an above zero
> chance that someone would want HASH_DEBUG without USE_ASSERT_CHECKING.
> I don't really know if that person exists. It certainly isn't me.

Yeah, it's really quite unclear what the existing HASH_DEBUG printout
is good for.  At least in our usage, it doesn't tell you anything
you can't discover from static code analysis.  I'm +1 for just
dropping it altogether.

            regards, tom lane



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
Next
From: Thomas Munro
Date:
Subject: Re: Memory leak of SMgrRelation object on standby