Re: Some efforts to get rid of "long" in our codebase - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Some efforts to get rid of "long" in our codebase
Date
Msg-id 24355712-a8be-48fc-b138-a213a97da754@eisentraut.org
Whole thread Raw
In response to Re: Some efforts to get rid of "long" in our codebase  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
On 06.11.25 13:17, Heikki Linnakangas wrote:
>> @@ -476,7 +476,7 @@ CatCachePrintStats(int code, Datum arg)
>>
>>          if (cache->cc_ntup == 0 && cache->cc_searches == 0)
>>              continue;            /* don't print unused caches */
>> -        elog(DEBUG2, "catcache %s/%u: %d tup, %ld srch, %ld+%ld=%ld 
>> hits, %ld+%ld=%ld loads, %ld invals, %d lists, %ld lsrch, %ld lhits",
>> +        elog(DEBUG2, "catcache %s/%u: %d tup, %" PRIu64 " srch, %" 
>> PRIu64 "+%" PRIu64 "=%" PRIu64 " hits, %" PRIu64 "+%" PRIu64 "=%" 
>> PRIu64 " loads, %" PRIu64 " invals, %d lists, %" PRIu64 " lsrch, %" 
>> PRIu64 " lhits",
>>               cache->cc_relname,
>>               cache->cc_indexoid,
>>               cache->cc_ntup,
> 
> Unfortunately PRIu64 makes these much longer and less readable. I don't 
> think there's much we can do about that though. Perhaps split the format 
> string to multiple lines?

You could also use unsigned long long int for these, to make the format 
strings more readable.




pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [Patch] Windows relation extension failure at 2GB and 4GB
Next
From: Peter Eisentraut
Date:
Subject: Re: Some efforts to get rid of "long" in our codebase