Re: rename es_epq_active to es_epqstate - Mailing list pgsql-hackers

From Tom Lane
Subject Re: rename es_epq_active to es_epqstate
Date
Msg-id 2448639.1737164612@sss.pgh.pa.us
Whole thread Raw
Responses Re: rename es_epq_active to es_epqstate
List pgsql-hackers
Junwang Zhao <zhjwpku@gmail.com> writes:
> ISTM Andres tend to use *es_epq_active* in a boolean way,
> like `if (es_epq_active) then`, but in the code base, all its usages
> follow pattern `if (es_epq_active == NULL) then`, so I propose to
> change es_epq_active to es_epqstate.

While I didn't especially love "es_epq_active" at the time,
I don't see that "es_epqstate" is much of an improvement:
it's an extremely generic name that conveys little information.
And renaming it now, years later, seems to add little except
back-patching hazards.  So I'd vote for leaving it alone.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Unicode full case mapping: PG_UNICODE_FAST, and standard-compliant UCS_BASIC
Next
From: Sergey Tatarintsev
Date:
Subject: Re: create subscription with (origin = none, copy_data = on)