Re: [PATCH] using arc4random for strong randomness matters. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] using arc4random for strong randomness matters.
Date
Msg-id 25920.1511372076@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] using arc4random for strong randomness matters.  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
Responses Re: [PATCH] using arc4random for strong randomness matters.
List pgsql-hackers
ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> More generally, why should we bother with an additional implementation?
>> Is this better than /dev/urandom, and if so why?

> If what is wanted is something more like /dev/urandom, one can call
> getentropy(2) (or on Linux, getrandom(2)) directly, which avoids having
> to open the device file each time.

I dunno, it seems like this is opening us to a new set of portability
hazards (ie, sub-par implementations of arc4random) with not much gain to
show for it.

IIUC, what this code actually does is reseed itself from /dev/urandom
every so often and work from a PRNG in between.  That's not a layer that
we need, because the code on top is already designed to cope with the
foibles of /dev/urandom --- or, to the extent it isn't, that's something
we have to fix anyway.  So it seems like having this optionally in place
just reduces what we can assume about the randomness properties of
pg_strong_random output, which doesn't seem like a good idea.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [PATCH] using arc4random for strong randomness matters.
Next
From: Simon Riggs
Date:
Subject: Re: [HACKERS] Commits don't block for synchronous replication