Re: checksum_impl.h fails cpluspluscheck - Mailing list pgsql-hackers

From Tom Lane
Subject Re: checksum_impl.h fails cpluspluscheck
Date
Msg-id 26025.1372565039@sss.pgh.pa.us
Whole thread Raw
In response to checksum_impl.h fails cpluspluscheck  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> ./src/include/storage/checksum_impl.h: In function �uint32 pg_checksum_block(char*, uint32)�:
> ./src/include/storage/checksum_impl.h:154: warning: comparison between signed and unsigned integer expressions

> We could exclude that file from the check, but it's also easy to fix by
> making the variables unsigned:
> ...
> Preferences?

Possibly use uint32 for consistency with the other vars in the function?
No real objection to unsigned int, though, since it's the same thing in
practice.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: checksum_impl.h fails cpluspluscheck
Next
From: Peter Geoghegan
Date:
Subject: Re: checksum_impl.h fails cpluspluscheck