Re: Issue with NULLS LAST, with postgres_fdw sort pushdown - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Issue with NULLS LAST, with postgres_fdw sort pushdown
Date
Msg-id 26733.1456981736@sss.pgh.pa.us
Whole thread Raw
In response to Re: Issue with NULLS LAST, with postgres_fdw sort pushdown  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
Responses Re: Issue with NULLS LAST, with postgres_fdw sort pushdown
List pgsql-hackers
Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> writes:
> On Thu, Mar 3, 2016 at 7:27 AM, Michael Paquier <michael.paquier@gmail.com>
> wrote:
>> Per explain.c, this looks inconsistent to me. Shouldn't NULLS LAST be
>> applied only if DESC is used in this ORDER BY clause?

> ... In this case we are constructing a query to be
> sent to the foreign server and it's better not to leave the defaults to be
> interpreted by the foreign server; in case it interprets them in different
> fashion. get_rule_orderby() also explicitly adds these options.

Yeah, I agree that we don't need to go out of our way to make the query
succinct here.  Explicitness is easier and safer too, so why not?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: Dockerfile for testing with Perl 5.8.8
Next
From: Craig Ringer
Date:
Subject: Re: TAP / recovery-test fs-level backups, psql enhancements etc