Re: string function - "format" function proposal - Mailing list pgsql-hackers

From Tom Lane
Subject Re: string function - "format" function proposal
Date
Msg-id 26848.1283783048@sss.pgh.pa.us
Whole thread Raw
In response to Re: string function - "format" function proposal  (Itagaki Takahiro <itagaki.takahiro@gmail.com>)
Responses Re: string function - "format" function proposal
List pgsql-hackers
Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
> On Mon, Sep 6, 2010 at 10:47 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> No, you need to use the I/O functions.  Not every type is guaranteed to
>> have a cast to text.

> One issue is that Pavel want to generate valid SQL statement using
> %v format. Boolean values are printed as t or f, so the unquoted
> values are not valid syntax.

So?  You'd need to quote the values anyway, in general.  If you want
something that will be valid SQL you'd better include the functionality
of quote_literal() in it.

> If we only use output functions, boolean values should be written as
> 't' or 'f' (single-quoted), Only numeric values can be unquoted on %v.

I'm not sure that it's a good idea to have any type-specific special
cases.  Failing to quote numeric values will bring in the whole set of
issues about how the parser initially types numeric constants, as in the
other thread over the weekend.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Interruptible sleeps (was Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!)
Next
From: Tom Lane
Date:
Subject: Re: string function - "format" function proposal