Re: Remove utils/acl.h from catalog/objectaddress.h - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Remove utils/acl.h from catalog/objectaddress.h
Date
Msg-id 26906.1583692137@sss.pgh.pa.us
Whole thread Raw
In response to Remove utils/acl.h from catalog/objectaddress.h  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> I noticed that catalog/objectaddress.h includes utils/acl.h for no 
> apparent reason.  It turns out this used to be needed but not anymore. 
> So removed it and cleaned up the fallout.  Patch attached.

Seems reasonable.  One thing I noticed is that if you are including
nodes/parsenodes.h explicitly in objectaddress.h, there seems little
point in the #include "nodes/pg_list.h" right beside it.

Sometime we really ought to make an effort to make our header inclusions
less of a mass of spaghetti.  But this patch needn't take on that load.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Allow to_date() and to_timestamp() to accept localized names
Next
From: David Fetter
Date:
Subject: Re: Use compiler intrinsics for bit ops in hash