Re: Restore support for USE_ASSERT_CHECKING in extensions only - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Restore support for USE_ASSERT_CHECKING in extensions only
Date
Msg-id 2718966.1736554509@sss.pgh.pa.us
Whole thread Raw
In response to Re: Restore support for USE_ASSERT_CHECKING in extensions only  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Andrew Kane <andrew@ankane.org> writes:
> I've updated the patch to make verify_compact_attribute a no-op.
> The extension sets USE_ASSERT_CHECKING, which is why the macro approach
> doesn't work (it won't take that path).

LGTM

> Also, it looks like it fails when creating the extension / loading the
> shared library (on Ubuntu), not when linking (as I misstated earlier).

I think that on macOS and perhaps a couple of other platforms, there'd
be a failure at extension link time.  But yeah, most Linuxen won't
tell you till load time.

            regards, tom lane



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Restore support for USE_ASSERT_CHECKING in extensions only
Next
From: David Rowley
Date:
Subject: Re: Restore support for USE_ASSERT_CHECKING in extensions only