Re: pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait
Date
Msg-id 27843.1312312995@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait
List pgsql-committers
Simon Riggs <simon@2ndQuadrant.com> writes:
> On Tue, Aug 2, 2011 at 6:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Fix incorrect initialization of ProcGlobal->startupBufferPinWaitBufId.
>>
>> It was initialized in the wrong place and to the wrong value. �With bad
>> luck this could result in incorrect query-cancellation failures in hot
>> standby sessions, should a HS backend be holding pin on buffer number 1
>> while trying to acquire a lock.

> Did I miss a bug report?

No, this was something I happened across in code-reading a few weeks ago
and had a note to myself to fix.  While looking at it today I found more
problems ... see second commit.

            regards, tom lane

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Move CheckRecoveryConflictDeadlock() call to a safer place.
Next
From: Simon Riggs
Date:
Subject: Re: pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait