Re: Very confusing installcheck behavior with PGXS - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Very confusing installcheck behavior with PGXS
Date
Msg-id 29567.1452182165@sss.pgh.pa.us
Whole thread Raw
In response to Re: Very confusing installcheck behavior with PGXS  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
Responses Re: Very confusing installcheck behavior with PGXS
List pgsql-hackers
Jim Nasby <Jim.Nasby@bluetreble.com> writes:
> On 1/7/16 9:12 AM, Tom Lane wrote:
>> (I'm also wondering how convert_sourcefiles() works at all in a vpath
>> build, considering that I don't see it doing anything like this ...)

> It's only looking at outputdir, which I suspect is never ambiguous.

Eh, no, look again.  What it's actually doing is reading $inputdir/input/
and converting into $outputdir/sql/, and reading $inputdir/output/ and
converting into $outputdir/expected/.  I guess that works, but again it's
kind of at variance with the normal expectation of VPATH behavior.  What
you'd expect is that $builddir/input files would override $srcdir/input
files; but as is, $builddir/input and $builddir/output are never examined
at all.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Generalizing SortSupport for text to work with char(n), bytea, and alternative opclasses
Next
From: Simon Riggs
Date:
Subject: Re: Proposal: Generic WAL logical messages