Request a Demo
Home   >   mailing lists

Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist
Date
Msg-id 2993271.1767036289@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist  (Kirill Reshke <reshkekirill@gmail.com>)
Responses Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist
List pgsql-hackers
Tree view 
Kirill Reshke <reshkekirill@gmail.com> writes:
> Should we then refactor code to avoid copying? I copied this code in
> [0] for the third time, so if this has a chance to be committed, there
> will be 3 times copied code...

Might not be a bad idea, but of course the devil is in the details.
What did you have in mind?  Split out a function to quote one
field value per record_out's rules?

            regards, tom lane

pgsql-hackers by date:

Previous
From: Kirill Reshke
Date:
Subject: Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist
Next
From: Kirill Reshke
Date:
Subject: Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist