Re: pgindent fails with perl 5.40 - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: pgindent fails with perl 5.40
Date
Msg-id 2EFDAF8C-0ED7-47A3-BD50-51DE29D279DF@yesql.se
Whole thread Raw
In response to Re: pgindent fails with perl 5.40  (Erik Wienhold <ewie@ewie.name>)
Responses Re: pgindent fails with perl 5.40
List pgsql-hackers
> On 8 Oct 2024, at 03:50, Erik Wienhold <ewie@ewie.name> wrote:

>> Calling the import method of an unknown package produces a warning
>> [...]
>> It will also detect cases where a user passes an argument when using a
>> package that does not provide its own import
>> [...]
>
> Because we use fatal warnings, pgindent fails.

I'm far from fluent in Perl, but my reading of this is that File::Spec doesn't
provide an import() function so explicitly listing devnull does nothing here.
Your diff should thus be a safe fix.  The devnull function existed already in
3.00 which was released just a hair over 2 decades ago so I think we can safely
assume any File::Spec we use to have it.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Make default subscription streaming option as Parallel
Next
From: Nisha Moond
Date:
Subject: Re: Conflict Detection and Resolution