stray references to SubscriptRef type - Mailing list pgsql-hackers

From Peter Eisentraut
Subject stray references to SubscriptRef type
Date
Msg-id 2eaa45e3-efc5-4d75-b082-f8159f51445f@eisentraut.org
Whole thread Raw
Responses Re: stray references to SubscriptRef type
List pgsql-hackers
There are several mentions in code comments of a SubscriptRef type, but 
that type does not exist and AFAICT never existed.  (Perhaps it existed 
in in-development code at some point.)

I think in several of those cases this clearly meant the type 
SubscriptingRef instead.  But the mentions in 
src/include/nodes/subscripting.h probably meant the various sbs_* functions.

If so, it would also be useful perhaps to document the leakproof 
expectations of the other sbs_* functions (sbs_fetch_old and 
sbs_check_subscripts).

See attached patch for my solution so far.


Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Eager aggregation, take 3
Next
From: Robert Haas
Date:
Subject: Re: Eager aggregation, take 3