Re: [BUG FIX]Connection fails with whitespace after keepalives parameter value - Mailing list pgsql-hackers

I poked into the ecpg end of this and found that the extra space
is coming from one production in ecpg.trailer that's carelessly
using cat_str (which inserts spaces) instead of makeN_str
(which doesn't).  So it's pretty trivial to fix, as attached.

I do not think we could rip out ECPGconnect's logic to remove the
spaces at runtime, because that would break existing ecpg
applications until they're recompiled.  It might be worth adding
a comment there about why it's being done, though.

I don't have a strong opinion one way or the other about whether
we should make libpq permissive about extra spaces (as per
Michael's patch).  I guess you could argue that all of these
fixes are consistent with the principle of "be conservative
with what you send and liberal with what you accept".  But at
most I'd fix these remaining things in HEAD.

            regards, tom lane

diff --git a/src/interfaces/ecpg/preproc/ecpg.trailer b/src/interfaces/ecpg/preproc/ecpg.trailer
index b6233e5e53..f3ab73bed6 100644
--- a/src/interfaces/ecpg/preproc/ecpg.trailer
+++ b/src/interfaces/ecpg/preproc/ecpg.trailer
@@ -348,7 +348,7 @@ connect_options: ColId opt_opt_value
         if (strcmp($3, "&") != 0)
             mmerror(PARSE_ERROR, ET_ERROR, "unrecognized token \"%s\"", $3);

-        $$ = cat_str(3, make2_str($1, $2), $3, $4);
+        $$ = make3_str(make2_str($1, $2), $3, $4);
     }
     ;

diff --git a/src/interfaces/ecpg/test/expected/connect-test5.c b/src/interfaces/ecpg/test/expected/connect-test5.c
index ec1514ed9a..fc650f5cd5 100644
--- a/src/interfaces/ecpg/test/expected/connect-test5.c
+++ b/src/interfaces/ecpg/test/expected/connect-test5.c
@@ -117,7 +117,7 @@ main(void)
 #line 56 "test5.pgc"


-    { ECPGconnect(__LINE__, 0, "unix:postgresql://localhost/ecpg2_regression?connect_timeout=180 &
client_encoding=sql_ascii", "regress_ecpg_user1" , "connectpw" , "main", 0); } 
+    { ECPGconnect(__LINE__, 0,
"unix:postgresql://localhost/ecpg2_regression?connect_timeout=180&client_encoding=sql_ascii", "regress_ecpg_user1" ,
"connectpw", "main", 0); } 
 #line 58 "test5.pgc"

     { ECPGdisconnect(__LINE__, "main");}
diff --git a/src/interfaces/ecpg/test/expected/connect-test5.stderr
b/src/interfaces/ecpg/test/expected/connect-test5.stderr
index 51cc18916a..037db21758 100644
--- a/src/interfaces/ecpg/test/expected/connect-test5.stderr
+++ b/src/interfaces/ecpg/test/expected/connect-test5.stderr
@@ -50,7 +50,7 @@
 [NO_PID]: sqlca: code: 0, state: 00000
 [NO_PID]: ecpg_finish: connection main closed
 [NO_PID]: sqlca: code: 0, state: 00000
-[NO_PID]: ECPGconnect: opening database ecpg2_regression on <DEFAULT> port <DEFAULT> with options connect_timeout=180
&client_encoding=sql_ascii for user regress_ecpg_user1 
+[NO_PID]: ECPGconnect: opening database ecpg2_regression on <DEFAULT> port <DEFAULT> with options
connect_timeout=180&client_encoding=sql_asciifor user regress_ecpg_user1 
 [NO_PID]: sqlca: code: 0, state: 00000
 [NO_PID]: ecpg_finish: connection main closed
 [NO_PID]: sqlca: code: 0, state: 00000