2009/9/9 Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp>:
> Alvaro Herrera <alvherre@commandprompt.com> wrote:
>> This INCLUDING STORAGE is supposed to copy reloptions?
>
> No. It copies only storage parameters of columns to control TOAST policy.
> It might be good to have some features to copy reloptions with convenient
> way, but it will be done in another patch.
>
>> to me it sounds like it's copying the
>> underlying storage i.e. data, which would be very surprising. What
>> about "INCLUDING STORAGE OPTIONS"?
It *would* be very surprising. An option to include data would
probably be called "INCLUDING DATA" =)
>
> Hmm, but we have the following syntax already:
> ALTER TABLE table ALTER COLUMN column SET STORAGE ...
> Do you also think it should be "SET STORAGE OPTION ..." ?
>
Personally, I think INCLUDING STORAGE makes as much sense as you can
expect using just one word, and as Itagaki-san points out it
correlates well with the syntax for ALTER COLUMN.
Cheers,
BJ
