Re: Simplify code building the LR conflict messages - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Simplify code building the LR conflict messages
Date
Msg-id 394105.1764298158@sss.pgh.pa.us
Whole thread Raw
In response to Simplify code building the LR conflict messages  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Simplify code building the LR conflict messages
List pgsql-hackers
Peter Smith <smithpb2250@gmail.com> writes:
> I couldn't think of a reason why the "; " string needed to be
> separated from the rest of the message like that. And when you combine
> the strings, the logic easily collapses into a single statement with
> less code and greater readability.

... and, probably, less ability of the compiler to verify that the
variadic arguments match the format string.  I think you've taken
this a bit too far.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: pg_recvlogical: Prevent flushed data from being re-sent after restarting replication
Next
From: Thomas Munro
Date:
Subject: Minor LLVM cleanups