Re: Shorter iterations of join_info_list - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Shorter iterations of join_info_list
Date
Msg-id 3952.1374639028@sss.pgh.pa.us
Whole thread Raw
In response to Shorter iterations of join_info_list  (Antonin Houska <antonin.houska@gmail.com>)
List pgsql-hackers
[ sorry for slow response, this month has been mostly crazy ]

Antonin Houska <antonin.houska@gmail.com> writes:
> As far as I understand, deconstruct_recurse() ensures that 
> SpecialJoinInfo of a new join always gets added to higher position in 
> join_info_list than SJ infos of all joins located below the new join in 
> the tree. I wonder if we can rely on that fact sometimes.

FWIW, I think of most of those planner lists as being unordered sets.
Depending on a particular ordering definitely adds fragility; so I'd
not want to introduce such a dependency without solid evidence of a
substantial speed improvement.  The cases you mention don't seem very
likely to offer any noticeable gain at all --- at least, I don't recall
seeing any of those functions show up high in profiles.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Suggestion for concurrent index creation using a single full scan operation
Next
From: Andrew Gierth
Date:
Subject: Re: Proposal/design feedback needed: WITHIN GROUP (sql standard ordered set aggregate functions)